Skip to content

+netrc for authentication#85

Open
shamilbi wants to merge 1 commit into
python-morgan:mainfrom
shamilbi:netrc
Open

+netrc for authentication#85
shamilbi wants to merge 1 commit into
python-morgan:mainfrom
shamilbi:netrc

Conversation

@shamilbi

@shamilbi shamilbi commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator

i hope it closes #63, could not test it against a real index that requires authentication

@grische

grische commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

i hope it closes #63, could not test it against a real index that requires authentication

I am against this kind of large code change if it cannot be tested at all. This probably conflicts heavily with #82 and I'd rather have this code here follow a similar pattern regarding the class structure.

@grische

grische commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@shamilbi if you still need authentication with the rework in #82 we probably should discuss redesigning this PR.
Like creating a centralised HTTP access, resolving credentials by URL (as artifacts can be on a different host, like a CDN) and adding tests for it.

If you don't need, we might want to close the PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Special credential characters in extra index url

2 participants